b-slim commented on a change in pull request #643: Hive 21785: Add task
queue/runtime stats per LLAP daemon to output
URL: https://github.com/apache/hive/pull/643#discussion_r288249250
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
##########
@@ -680,8 +678,8 @@ void tryScheduleUnderLock(final TaskWrapper taskWrapper)
throws RejectedExecutio
LOG.info("Attempting to execute {}", taskWrapper);
}
TaskRunnerCallable task = taskWrapper.getTaskRunnerCallable();
- task.setWmCountersRunning();
ListenableFuture<TaskRunner2Result> future = executorService.submit(task);
+ task.setWmCountersRunning();
Review comment:
this is more a question than a comment. Am not very familiar with this part
of the code, but submitting a runnable does not necessarily means it is running
right ? for instance if the pool size is smaller than the number of runnable ?
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
