pvary commented on a change in pull request #643: Hive 21785: Add task
queue/runtime stats per LLAP daemon to output
URL: https://github.com/apache/hive/pull/643#discussion_r288430843
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/counters/WmFragmentCounters.java
##########
@@ -119,6 +123,21 @@ public void dumpToTezCounters(TezCounters tezCounters,
boolean isLast) {
for (int i = 0; i < fixedCounters.length(); ++i) {
tezCounters.findCounter(LlapWmCounters.values()[i]).setValue(fixedCounters.get(i));
}
+
+ // add queue and runtime (together with task count) on a "per daemon" level
+ // to the Tez counters.
+ if (addTaskTimeCounters) {
Review comment:
Do we expect to calculate this values to be so time consuming to merit it's
own configuration value? Having too many configs had been a continuous
complaint from our users, so lately I try to avoid them if not necessary.
Or we do this because of backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
