ashutosh-bapat commented on a change in pull request #648: HIVE-21783: Accept
Hive connections from the same domain without authentication.
URL: https://github.com/apache/hive/pull/648#discussion_r288928865
##########
File path: service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java
##########
@@ -75,6 +89,70 @@ private PlainSaslHelper() {
throw new UnsupportedOperationException("Can't initialize class");
}
+ public static final class DualSaslTransportFactory extends TTransportFactory
{
+ TTransportFactory otherFactory;
+ TTransportFactory noAuthFactory;
+ String hiveHost;
+
+ public DualSaslTransportFactory(TTransportFactory otherFactory, String
hiveHost)
+ throws LoginException {
+ this.noAuthFactory =
getPlainTransportFactory(AuthMethods.NONE.toString());
+ this.otherFactory = otherFactory;
+ this.hiveHost = hiveHost;
+ }
+
+ // Return true if the IP address is from the same domain as the server.
+ private boolean isSameDomainConnection(InetAddress remoteInetAddress) {
+ String[] hiveHostSplit = null;
+ if (hiveHost != null) {
+ hiveHostSplit = hiveHost.split("\\.");
+ }
+
+ String clientHostName = remoteInetAddress.getCanonicalHostName();
+ String[] clientHostSplit = null;
+ if (clientHostName != null) {
+ clientHostSplit = clientHostName.split("\\.");
+ }
+
+ // TODO: the callers should also pass the server address or obtain in by
using some other
+ // method. Then check whether the connection's remote address is from
the same domain as
+ // the server. For now, for the sake of testing, return true. We need
to understand what
+ // exactly it means to have connection from the same domain.
+ // For now, two hosts are in the same domain if the last two parts in
their hostname are same.
+ if (hiveHostSplit.length >= 2 && clientHostSplit.length >= 2) {
+ if (hiveHostSplit[0] != null &&
hiveHostSplit[0].equalsIgnoreCase(clientHostSplit[0]) &&
+ hiveHostSplit[1] != null &&
hiveHostSplit[1].equalsIgnoreCase(clientHostSplit[1])) {
+ return true;
+ }
+ }
+
+ return false;
+ }
+
+ @Override
+ public TTransport getTransport(final TTransport trans) {
+ TSocket tSocket = null;
+ // Attempt to avoid authentication if only we can fetch the client IP
address and it
+ // happens to be from the same domain as the server.
+ if (trans instanceof TSocket) {
+ tSocket = (TSocket) trans;
+ } else if (trans instanceof TSaslServerTransport) {
+ TSaslServerTransport saslTrans = (TSaslServerTransport) trans;
+ tSocket = (TSocket)(saslTrans.getUnderlyingTransport());
+ }
+ InetAddress remoteAddress = tSocket != null ?
tSocket.getSocket().getInetAddress() : null;
+ if (remoteAddress != null && isSameDomainConnection(remoteAddress)) {
+ LOG.info("No authentication performed because the client connection is
from the same " +
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
