b-slim commented on a change in pull request #633: HIVE-21740: Collect LLAP
execution latency metrics
URL: https://github.com/apache/hive/pull/633#discussion_r289146624
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -3154,4 +3160,22 @@ public void taskInfoUpdated(TezTaskAttemptID attemptId,
boolean isGuaranteed) {
+ attemptId + ", " + newState);
sendUpdateMessageAsync(ti, newState);
}
+
+ private void updateMetrics(TaskAttemptImpl taskAttempt) {
+ // Only do it for successful map tasks
+ if (!TaskAttemptState.SUCCEEDED.equals(taskAttempt.getState()) ||
!isMapTask(taskAttempt)) {
+ return;
+ }
+ // Check if this task was already assigned to a node
+ NodeInfo nodeInfo = knownTasks.get(taskAttempt).assignedNode;
+ if (nodeInfo == null) {
+ return;
+ }
+
+ metrics.addTaskLatency(nodeInfo.shortStringBase,
taskAttempt.getFinishTime() - taskAttempt.getLaunchTime());
+ }
+
+ private boolean isMapTask(TaskAttemptImpl taskAttempt) {
Review comment:
is this really the best way to find if this is a map task ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
