odraese commented on a change in pull request #657: HIVE-21822: Expose
LlapDaemon metrics through a new API method
URL: https://github.com/apache/hive/pull/657#discussion_r290427779
##########
File path: llap-common/src/protobuf/LlapDaemonProtocol.proto
##########
@@ -211,6 +211,14 @@ message PurgeCacheResponseProto {
optional int64 purged_memory_bytes = 1;
}
+message GetLoadMetricsRequestProto {
+}
+
+message GetLoadMetricsResponseProto {
+ optional int64 num_executors_available = 1;
Review comment:
i would change this to a Map<String,int64> for numeric values and add map
entries for each counter/metric rather than listing out each of them as
separate message values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
