pvary commented on a change in pull request #660: HIVE-21823: New metrics to
get the average queue length / free executor number for a given time window
URL: https://github.com/apache/hive/pull/660#discussion_r290628508
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorMetrics.java
##########
@@ -397,4 +425,106 @@ public JvmMetrics getJvmMetrics() {
public String getName() {
return name;
}
+
+ /**
+ * Generate time aware average for data points.
+ * For example if we have 3s when the queue size is 1, and 1s when the queue
size is 2 then the
+ * calculated average should be (3*1+1*2)/4 = 1.25.
+ */
+ @VisibleForTesting
+ static class TimedAverageMetrics {
+ private final int windowDataSize;
+ private final long windowTimeSize;
+ private final Data[] data;
+ private int nextPos = 0;
+
+ /**
+ * Creates and initializes the metrics object.
+ * @param windowDataSize The maximum number of samples stored
+ * @param windowTimeSize The time window used to generate the average in
nanoseconds
+ */
+ TimedAverageMetrics(int windowDataSize, long windowTimeSize) {
+ this(windowDataSize, windowTimeSize, System.nanoTime());
Review comment:
According to the documentation:
"The value returned represents nanoseconds since some fixed but arbitrary
origin time (perhaps in the future, so values may be negative)."
That is why I used the System.nanoTime. Will move them outside the window.
Good catch. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
