pvary commented on a change in pull request #665: HIVE-21832: New metrics to
get the average queue/serving/response time
URL: https://github.com/apache/hive/pull/665#discussion_r291661699
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorMetrics.java
##########
@@ -195,14 +202,22 @@ private LlapDaemonExecutorMetrics(String displayName,
JvmMetrics jm, String sess
this.executorThreadUserTime[i] = registry.newGauge(miu, 0L);
this.executorNames.put(ContainerRunnerImpl.THREAD_NAME_FORMAT_PREFIX +
i, i);
}
+ if (simpleAverageWindowDataSize > 0) {
+ this.queueTime = new
SynchronizedDescriptiveStatistics(simpleAverageWindowDataSize);
Review comment:
The 2 new averages are updated in InternalCompletionListener.onSuccess
callback which is running in a separate thread specifically to make sure that
the other tasks are not rejected because of this:
` // Callback on a separate thread so that when a task completes, the
thread in the main queue
// is actually available for execution and will not potentially result
in a RejectedExecution
`
There is only one more place when these stats are accessed - Metrics
collection, which should not cause problem either.
Am I right when I think that this means that this will not cause issue for
us until it is not used elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
