daijyc commented on a change in pull request #662: Hive-21787: Metastore table
cache enhancement
URL: https://github.com/apache/hive/pull/662#discussion_r291864278
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -404,8 +407,7 @@ public static long updateUsingNotificationEvents(RawStore
rawStore, long lastEve
/**
* This initializes the caches in SharedCache by getting the objects from
Metastore DB via
* ObjectStore and populating the respective caches
- */
- static void prewarm(RawStore rawStore) {
+ */ static void prewarm(RawStore rawStore) {
if (isCachePrewarmed.get()) {
Review comment:
Wonder if we shall stop loading more tables if cache is full during prewarm.
Otherwise, it´s guarantee to load all tables and evict earlier tables, which
seems unnecessary. But we can do it in a followup ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
