maheshk114 commented on a change in pull request #664: HIVE-21762: REPL DUMP to
support new format for replication policy input to take included tables list.
URL: https://github.com/apache/hive/pull/664#discussion_r291880791
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -924,6 +926,30 @@ replConfigsList
keyValueProperty (COMMA keyValueProperty)* -> ^(TOK_REPL_CONFIG_LIST
keyValueProperty+)
;
+replTableLevelPolicy
+@init { pushMsg("replication table level policy definition", state); }
+@after { popMsg(state); }
+ :
+ ((replTablesIncludeList=replTablesList) (DOT
replTablesExcludeList=replTablesList)?)
+ -> ^(TOK_REPL_TABLES $replTablesIncludeList $replTablesExcludeList?)
+ ;
+
+replTablesList
+@init { pushMsg("replication table name or comma separated table names pattern
list", state); }
+@after { popMsg(state); }
+ :
+ (replTable=identifier) -> ^(TOK_TABNAME $replTable)
Review comment:
i think we should follow this same as create table. if create table allows
creating a table with name having * and +, then we should allow else, it should
fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
