maheshk114 commented on a change in pull request #667: HIVE-21844 : HMS schema 
Upgrade Script is failing with NPE
URL: https://github.com/apache/hive/pull/667#discussion_r291884417
 
 

 ##########
 File path: beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java
 ##########
 @@ -116,6 +116,10 @@ ColorBuffer getOutputString(Rows rows, Rows.Row row, 
String delim) {
       if (buf.getVisibleLength() > 0) {
         buf.green(delim);
       }
+ 
+      if (row.values[i] == null) {
 
 Review comment:
   The issue is coming only for mysql 5.7 ...no testing till now has been done 
for mysql 5.7 ..all previous test are done for 5.6. The null check will not 
create any problem as if the row header is not present , no point color coding 
the content.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to