sam-an-cloudera commented on a change in pull request #661: Hive-21833: Ranger
Authorization in Hive based on object ownership
URL: https://github.com/apache/hive/pull/661#discussion_r292191196
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -494,7 +494,7 @@ static void prewarm(RawStore rawStore) {
AggrStats aggrStatsAllButDefaultPartition = null;
if (!table.getPartitionKeys().isEmpty()) {
Deadline.startTimer("getPartitions");
- partitions = rawStore.getPartitions(catName, dbName, tblName,
Integer.MAX_VALUE);
+ partitions = rawStore.getPartitions(catName, dbName, tblName,
-1);
Review comment:
the limit = Integer.MAX_VALUE was used in a couple other places, e.g. in
HiveMetaStore.java, I saw
for (Partition partition : ms.getPartitions(catName, dbName, tableName,
Integer.MAX_VALUE)) {
. Since RawStore is an interface, I am not sure how to change it to treat
MAX_VALUE as -1. Also the exception was thrown from Mysql jdbc jar for value
higher than 50million rows. The RawStore comment does indcate if no limit
desired, we should pass in -1. I am keep it here just for passing build/local
test, etc. I guess we can fix other places in a separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
