sam-an-cloudera commented on a change in pull request #662: Hive-21787: 
Metastore table cache enhancement
URL: https://github.com/apache/hive/pull/662#discussion_r292205532
 
 

 ##########
 File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 ##########
 @@ -120,14 +118,15 @@
   private Configuration conf;
   private static boolean areTxnStatsSupported;
   private PartitionExpressionProxy expressionProxy = null;
+  private static String lock = "L";
+  private static boolean sharedCacheInited = false;
   private static SharedCache sharedCache = new SharedCache();
-  private static  boolean canUseEvents = false;
+  private static boolean canUseEvents = false;
   private static long lastEventId;
 
-  static final private Logger LOG = 
LoggerFactory.getLogger(CachedStore.class.getName());
+  private static final Logger LOG = 
LoggerFactory.getLogger(CachedStore.class.getName());
 
-  @Override
-  public void setConf(Configuration conf) {
+  @Override public void setConf(Configuration conf) {
 
 Review comment:
   and sure, I will wait till your HIVE-21637 goes in or coordinate with you 
how best to go. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to