maheshk114 commented on a change in pull request #668: HIVE-21841 : Add 
configuration to specify the hostname of HMS leader …to run housekeeping tasks 
in.
URL: https://github.com/apache/hive/pull/668#discussion_r294132096
 
 

 ##########
 File path: 
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java
 ##########
 @@ -75,7 +79,16 @@ public static void startMetaStore(final int port,
       @Override
       public void run() {
         try {
-          HiveMetaStore.startMetaStore(port, bridge, finalConf);
+          Lock startLock = null;
+          Condition startCondition = null;
+          AtomicBoolean startedServing = null;
+          if (withHouseKeepingThreads) {
+            startLock = new ReentrantLock();
+            startCondition = startLock.newCondition();
+            startedServing = new AtomicBoolean();
 
 Review comment:
   its better to initialize AtomicBoolean with false ..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to