sankarh commented on a change in pull request #673: HIVE-21763: Incremental
replication to allow changing include/exclude tables list in replication policy.
URL: https://github.com/apache/hive/pull/673#discussion_r294606978
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -894,12 +894,20 @@ replDumpStatement
@after { popMsg(state); }
: KW_REPL KW_DUMP
(dbName=identifier) (DOT tablePolicy=replTableLevelPolicy)?
+ (KW_REPLACE replacePolicy=replReplacePolicy)?
(KW_FROM (eventId=Number)
(KW_TO (rangeEnd=Number))?
(KW_LIMIT (batchSize=Number))?
)?
(KW_WITH replConf=replConfigs)?
- -> ^(TOK_REPL_DUMP $dbName $tablePolicy? ^(TOK_FROM $eventId (TOK_TO
$rangeEnd)? (TOK_LIMIT $batchSize)?)? $replConf?)
+ -> ^(TOK_REPL_DUMP $dbName $tablePolicy? $replacePolicy? ^(TOK_FROM
$eventId (TOK_TO $rangeEnd)? (TOK_LIMIT $batchSize)?)? $replConf?)
+ ;
+
+replReplacePolicy
Review comment:
It is same. Only difference is replReplacePolicy takes token TOK_REPLACE
additionally. I think, this can be changed to have common code. Will make this
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
