sankarh commented on a change in pull request #679: HIVE-21764 : REPL DUMP
should detect and bootstrap any rename table events where old table was
excluded but renamed table is included.
URL: https://github.com/apache/hive/pull/679#discussion_r296103088
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/DropTableHandler.java
##########
@@ -32,9 +34,18 @@
@Override
public List<Task<? extends Serializable>> handle(Context context)
throws SemanticException {
- DropTableMessage msg =
deserializer.getDropTableMessage(context.dmd.getPayload());
- String actualDbName = context.isDbNameEmpty() ? msg.getDB() :
context.dbName;
- String actualTblName = msg.getTable();
+ String actualDbName;
+ String actualTblName;
+ if (context.dmd.getDumpType() == DumpType.EVENT_DROP_TABLE) {
Review comment:
I think, if flow is for EVENT_RENAME_DROP_TABLE and else flow for
EVENT_DROP_TABLE. Looks incorrect here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
