sankarh commented on a change in pull request #679: HIVE-21764 : REPL DUMP
should detect and bootstrap any rename table events where old table was
excluded but renamed table is included.
URL: https://github.com/apache/hive/pull/679#discussion_r296256293
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/event/filters/ReplEventFilter.java
##########
@@ -30,12 +31,22 @@ public ReplEventFilter(final ReplScope replScope) {
this.replScope = replScope;
}
+ // Return false if all the tables are included, as bootstrap during rename
is done only in case filter set for tables.
+ boolean isAlterDuringTableLevelReplication(final NotificationEvent event) {
+ if (replScope.includeAllTables() ||
!replScope.getDbNamePattern().matcher(event.getDbName()).matches()) {
Review comment:
Well. my point is not about exposing dbNamePattern. It's more about
functionality related to ReplScope. So, the db matching is a functionality
which can be kept isolated within ReplScope. Why need to expose this
functionality outside? Also, having it inside ReplScope would make others to
use it in future instead of duplicating it in the caller.
Anyways, it's your call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
