asinkovits commented on a change in pull request #683: HIVE-21846: Create a
thread in TezAM which periodically fetches LlapDaemon metrics
URL: https://github.com/apache/hive/pull/683#discussion_r297512929
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -790,6 +794,8 @@ public void run() {
}
}, 0, 10000L, TimeUnit.MILLISECONDS);
+ llapMetricsCollector.start();
Review comment:
Now this is a bit tricky. I didn't wanted to do a tight coupling between the
registry and the collector, but I agree that there is a dependency between the
starts. So I've added the ServiceStateChangeListener to the Collector, and
subscribed to the state changes of the registry. This way we can ensure, that
the starts and stops happen in the correct way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
