sankarh commented on a change in pull request #688: HIVE-21886 : REPL - With
table list - Handle rename events during replace policy
URL: https://github.com/apache/hive/pull/688#discussion_r297605541
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterTableHandler.java
##########
@@ -135,8 +173,15 @@ private boolean handleForTableLevelReplication(Context
withinContext) {
return false;
}
+ // In case of replace policy, even if the old table matches the new
policy, none of the events including create
+ // table will be replayed as the old table is set of bootstrap by
replace handler. So rename event can be skipped.
+ if (ReplUtils.tableIncludedInReplScope(withinContext.replScope,
oldName)) {
Review comment:
This check is not significant as the else flow is also return false. Shall
remove it and keep the comment to explain this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
