sankarh commented on a change in pull request #688: HIVE-21886 : REPL - With
table list - Handle rename events during replace policy
URL: https://github.com/apache/hive/pull/688#discussion_r297656264
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterTableHandler.java
##########
@@ -92,16 +93,40 @@ private Scenario
scenarioType(org.apache.hadoop.hive.metastore.api.Table before,
}
}
- // return true, if event needs to be dumped, else return false.
- private boolean handleForTableLevelReplication(Context withinContext) {
- String oldName = before.getTableName();
- String newName = after.getTableName();
+ private boolean isSetForBootstrapByReplaceHandler(Context withinContext,
String tblName) {
Review comment:
ReplaceHandler is something odd. Rename and Replace seems to give similar
meaning in this context. Also, we don't set any table for bootstrap. The term
"set" confuses with bootstrapTables list but we don't refer to that list here.
So, better to change in my opinion.
May be, isTableCandidateForBootstrapByReplacePolicy is also relevant. Think
about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
