sankarh commented on a change in pull request #688: HIVE-21886 : REPL - With
table list - Handle rename events during replace policy
URL: https://github.com/apache/hive/pull/688#discussion_r298020420
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AlterTableHandler.java
##########
@@ -118,25 +147,25 @@ private boolean handleForTableLevelReplication(Context
withinContext) {
// If the old table was in the list of tables to be bootstrapped which
is a multi rename case, the old table
// is removed from the list of tables to be bootstrapped and new one is
added.
- if (oldTableIsPresent) {
+ if (oldTableInBootstrapList) {
withinContext.addToListOfTablesForBootstrap(newName);
return false;
}
- // If both old and new table satisfies the filter and old table is
present at target, then dump the rename event.
- LOG.info("both old and new table satisfies the filter");
+ // If both old and new table satisfies the policy and old table is
present at target, then dump the rename event.
+ LOG.info("both old and new table satisfies the policy");
return true;
} else {
- // if the old table does not satisfies the filter, but the new one
satisfies, then the new table should be
+ // if the old table does not satisfies the policy, but the new one
satisfies, then the new table should be
// added to the list of tables to be bootstrapped and don't dump the
event.
if (ReplUtils.tableIncludedInReplScope(withinContext.replScope,
newName)) {
LOG.info("Table " + newName + " is added for bootstrap " + " during
rename from " + oldName);
withinContext.addToListOfTablesForBootstrap(newName);
return false;
}
- // if both old and new table does not satisfies the filter, then don't
dump the event.
- LOG.info("both old and new table not satisfies the filter");
+ // if both old and new table does not satisfies the policy, then don't
dump the event.
+ LOG.info("both old and new table not satisfies the policy");
Review comment:
Shall log table names also in the log message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
