odraese commented on a change in pull request #690: HIVE-21910: Multiple target
location generation in HostAffinitySplitLocationProvider
URL: https://github.com/apache/hive/pull/690#discussion_r298297521
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java
##########
@@ -72,11 +78,17 @@ public HostAffinitySplitLocationProvider(List<String>
knownLocations) {
FileSplit fsplit = (FileSplit) split;
String splitDesc = "Split at " + fsplit.getPath() + " with offset= " +
fsplit.getStart()
+ ", length=" + fsplit.getLength();
- List<String> preferredLocations = preferLocations(fsplit);
- String location =
- preferredLocations.get(determineLocation(preferredLocations,
fsplit.getPath().toString(),
- fsplit.getStart(), splitDesc));
- return (location != null) ? new String[] { location } : null;
+ List<String> preferredLocations = new ArrayList<>(preferLocations(fsplit));
Review comment:
I think, we might want to consider rolling back the patch that introduced
preferred locations in the first place (HIVE-21232). This caused noticeable
skew within the LLAP cluster. Let's verify with @t3rmin4t0r but I would assume
that we go back to original behavior, where we always use known locations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
