pvary commented on a change in pull request #690: HIVE-21910: Multiple target
location generation in HostAffinitySplitLocationProvider
URL: https://github.com/apache/hive/pull/690#discussion_r298557620
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java
##########
@@ -52,13 +52,19 @@
private final List<String> locations;
private final Set<String> locationSet;
+ private final int numberOfLocations;
- public HostAffinitySplitLocationProvider(List<String> knownLocations) {
+ public HostAffinitySplitLocationProvider(List<String> knownLocations, int
numberOfLocations) {
Preconditions.checkState(knownLocations != null &&
!knownLocations.isEmpty(),
HostAffinitySplitLocationProvider.class.getName() +
" needs at least 1 location to function");
+ Preconditions.checkArgument(numberOfLocations >= 0,
Review comment:
Yeah - remained from previous thoughts
Set to 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
