odraese commented on a change in pull request #698: HIVE-21912: Implement 
DisablingDaemonStatisticsHandler
URL: https://github.com/apache/hive/pull/698#discussion_r300025964
 
 

 ##########
 File path: 
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 ##########
 @@ -132,6 +133,18 @@ private void unregisterWorker() throws IOException {
     }
   }
 
+  public ConfigChangeLockResult lockForConfigChange(long 
nextMinConfigChangeTime) {
 
 Review comment:
   Being aware, that this is not the "standard", I would still like to suggest 
adding a JavaDoc here for the public method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to