odraese commented on a change in pull request #699: HIVE-21908: LlapDaemon node
status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300091138
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
##########
@@ -213,6 +215,10 @@ public synchronized void setCapacity(int newNumExecutors,
int newWaitQueueSize)
numSlotsAvailable.addAndGet(newNumExecutors - maxParallelExecutors);
maxParallelExecutors = newNumExecutors;
waitQueue.setWaitQueueSize(newWaitQueueSize);
+ if (metrics != null) {
Review comment:
I found only one case (test) where metrics could be passed in a null. So, I
would wonder if it would make sense to mock metrics in that test and to always
assume/verify that we have metrics being passed in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
