vineetgarg02 commented on a change in pull request #696: HIVE-18842
URL: https://github.com/apache/hive/pull/696#discussion_r300178551
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -7297,8 +7435,19 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
// Add NOT NULL constraint check
input = genConstraintsPlan(dest, qb, input);
- // Add sorting/bucketing if needed
- input = genBucketingSortingDest(dest, input, qb, tableDescriptor,
destinationTable, rsCtx);
+ if (destinationTable.isMaterializedView() &&
+ mvRebuildMode ==
MaterializationRebuildMode.INSERT_OVERWRITE_REBUILD) {
+ // Data organization (DISTRIBUTED, SORTED, CLUSTERED) for materialized
view
+ // TODO: We only do this for a full rebuild
Review comment:
`CLUSTERED ON` `SORTED ON` will be silently ignored for rest of the build
types. Do you think it is good idea to log warning in that case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
