jcamachor commented on a change in pull request #696: HIVE-18842 URL: https://github.com/apache/hive/pull/696#discussion_r300232292
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/view/CreateViewDesc.java ########## @@ -70,21 +72,28 @@ private String storageHandler; // only used for materialized views private Map<String, String> serdeProps; // only used for materialized views private Set<String> tablesUsed; // only used for materialized views + private List<String> sortColNames; // only used for materialized views + private List<FieldSchema> sortCols; // only used for materialized views Review comment: You are right, this is not really required. We only use it to print the column names together with their types in the explain for `CREATE MATERIALIZED VIEW` statement. Logic is similar to partition columns, this will only be needed if we store these columns as entries in the SORT / BUCKET columns in metastore (as we do for normal tables), but currently we do not do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
