asinkovits commented on a change in pull request #699: HIVE-21908: LlapDaemon
node status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300345174
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
##########
@@ -213,6 +215,10 @@ public synchronized void setCapacity(int newNumExecutors,
int newWaitQueueSize)
numSlotsAvailable.addAndGet(newNumExecutors - maxParallelExecutors);
maxParallelExecutors = newNumExecutors;
waitQueue.setWaitQueueSize(newWaitQueueSize);
+ if (metrics != null) {
Review comment:
Yes, this makes sense. I think removing all those null checks just makes the
code more readable. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
