pvary commented on a change in pull request #699: HIVE-21908: LlapDaemon node
status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300630116
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorInfo.java
##########
@@ -28,7 +28,9 @@
public enum LlapDaemonExecutorInfo implements MetricsInfo {
ExecutorMetrics("Llap daemon cache related metrics"),
ExecutorMaxFreeSlots("Sum of wait queue size and number of executors"),
- ExecutorNumExecutorsPerInstance("Total number of executor threads per node"),
+ ExecutorNumExecutors("Total number of executor threads"),
+ ExecutorMaxConfiguredFreeSlots("Sum of the configured wait queue size and
the configured number of executors"),
Review comment:
nit: I would name it ExecutorMaxFreeSlotsConfigured
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
