maheshk114 commented on a change in pull request #705: HIVE-21958 : The list of
table expression in the inclusion and exclusion list should be separated by '|'
instead of comma.
URL: https://github.com/apache/hive/pull/705#discussion_r300948134
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestTableLevelReplicationScenarios.java
##########
@@ -313,8 +313,8 @@ public void testIncorrectTablePolicyInReplDump() throws
Throwable {
}
Assert.assertTrue(failed);
- // Invalid pattern where we didn't enclose table pattern within single or
double quotes.
- replPolicy = primaryDbName + ".[t1].[t2]";
+ // Invalid pattern where where table list is empty.
+ replPolicy = primaryDbName + ".''.'t2'";
Review comment:
it's confusing ..if empty list ..that means include all ? if yes, then user
has to give empty exclude list or exclude list as * for dump only function ? i
think for simplicity we should not allow this special case ..if user wants then
they can use regex to exclude all tables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
