kgyrtkirk commented on a change in pull request #703: HIVE-21959 Clean up
Concatenate and Msck DDL commands
URL: https://github.com/apache/hive/pull/703#discussion_r301044303
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##########
@@ -2061,11 +2057,9 @@ private void analyzeAlterTablePartMergeFiles(ASTNode
ast,
}
// throw a HiveException for other than rcfile and orcfile.
- if (!((inputFormatClass.equals(RCFileInputFormat.class) ||
- (inputFormatClass.equals(OrcInputFormat.class))))) {
+ if (!(inputFormatClass.equals(RCFileInputFormat.class) ||
inputFormatClass.equals(OrcInputFormat.class))) {
Review comment:
note: I think that instead of class.equals; we should use marker interfaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
