granthenke commented on a change in pull request #733: HIVE-12971: Add Support for Kudu Tables URL: https://github.com/apache/hive/pull/733#discussion_r307416102
########## File path: kudu-handler/src/java/org/apache/hadoop/hive/kudu/KuduHiveUtils.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.kudu; + +import java.security.AccessController; +import java.util.Map; +import java.util.Properties; +import java.util.Set; +import javax.security.auth.Subject; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.utils.StringUtils; +import org.apache.hadoop.hive.serde2.SerDeException; +import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo; +import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory; +import org.apache.hadoop.io.Text; +import org.apache.hadoop.security.Credentials; +import org.apache.hadoop.security.token.Token; +import org.apache.kudu.ColumnTypeAttributes; +import org.apache.kudu.Type; +import org.apache.kudu.client.KuduClient; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.hadoop.hive.kudu.KuduStorageHandler.KUDU_MASTER_ADDRS_KEY; + +/** + * A collection of static utility methods for the Kudu Hive integration. + * This is useful for code sharing. + */ +public final class KuduHiveUtils { + + private static final Logger LOG = LoggerFactory.getLogger(KuduHiveUtils.class); + + private static final Text KUDU_TOKEN_KIND = new Text("kudu-authn-data"); + + private KuduHiveUtils() {} + + /** + * Returns the union of the configuration and table properties with the + * table properties taking precedence. + */ + public static Configuration createOverlayedConf(Configuration conf, Properties tblProps) { + Configuration newConf = new Configuration(conf); + for (Map.Entry<Object, Object> prop : tblProps.entrySet()) { + newConf.set((String) prop.getKey(), (String) prop.getValue()); + } + return newConf; + } + + public static String getMasterAddresses(Configuration conf) { + // Load the default configuration. + String masterAddresses = HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_KUDU_MASTER_ADDRESSES_DEFAULT); + if (StringUtils.isEmpty(masterAddresses)) { + throw new IllegalStateException("Kudu master addresses not specified in configuration"); Review comment: I added a unit test and a negative q test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
