jcamachor commented on a change in pull request #741: HIVE-22046
URL: https://github.com/apache/hive/pull/741#discussion_r310738062
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -3089,7 +3089,7 @@ public Table get_table(final String dbname, final String
name) throws MetaExcept
NoSuchObjectException {
String[] parsedDbName = parseDbName(dbname, conf);
return getTableInternal(
- parsedDbName[CAT_NAME], parsedDbName[DB_NAME], name, null, null,
false);
+ parsedDbName[CAT_NAME], parsedDbName[DB_NAME], name, null, null,
false, null);
Review comment:
Observe in this case, retrieve column stats (parameter before null) is
false. Basically, when we retrieve a given table, if we want to retrieve stats,
we will only retrieve stats for a given engine. Since this is not a public API
but rather a private method, I am thinking whether I should eliminate the
boolean and document behavior as 'if engine is specified, retrieve column stats
for that engine; if engine is null, do not retrieve column stats'. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
