b-slim commented on a change in pull request #723: [HIVE-20683] Add the Ability
to push Dynamic Between and Bloom filters to Druid
URL: https://github.com/apache/hive/pull/723#discussion_r314801856
##########
File path:
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java
##########
@@ -894,4 +944,257 @@ public static IndexSpec getIndexSpec(Configuration jc) {
ImmutableList<AggregatorFactory> aggregatorFactories =
aggregatorFactoryBuilder.build();
return Pair.of(dimensions, aggregatorFactories.toArray(new
AggregatorFactory[0]));
}
+
+ // Druid only supports String,Long,Float,Double selectors
+ private static Set<TypeInfo> druidSupportedTypeInfos =
ImmutableSet.<TypeInfo>of(
+ TypeInfoFactory.stringTypeInfo, TypeInfoFactory.charTypeInfo,
+ TypeInfoFactory.varcharTypeInfo, TypeInfoFactory.byteTypeInfo,
+ TypeInfoFactory.intTypeInfo, TypeInfoFactory.longTypeInfo,
+ TypeInfoFactory.shortTypeInfo, TypeInfoFactory.doubleTypeInfo
+ );
+
+ private static Set<TypeInfo> stringTypeInfos = ImmutableSet.<TypeInfo>of(
+ TypeInfoFactory.stringTypeInfo,
+ TypeInfoFactory.charTypeInfo, TypeInfoFactory.varcharTypeInfo
+ );
+
+
+ public static org.apache.druid.query.Query
addDynamicFilters(org.apache.druid.query.Query query,
Review comment:
what you think about extracting all those utils into a new class called
`DruidExpressionsUtils` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
