vineetgarg02 commented on a change in pull request #746: HIVE-22074: Slow 
compilation due to IN to OR transformation
URL: https://github.com/apache/hive/pull/746#discussion_r316405451
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
 ##########
 @@ -1220,16 +1220,26 @@ protected ExprNodeDesc 
getXpathOrFuncExprNodeDesc(ASTNode expr,
             }
             outputOpList.add(nullConst);
           }
+
           if (!ctx.isCBOExecuted()) {
-            ArrayList<ExprNodeDesc> orOperands = 
TypeCheckProcFactoryUtils.rewriteInToOR(children);
-            if (orOperands != null) {
-              if (orOperands.size() == 1) {
-                orOperands.add(new 
ExprNodeConstantDesc(TypeInfoFactory.booleanTypeInfo, false));
+
+            HiveConf conf;
+            try {
+              conf = Hive.get().getConf();
 
 Review comment:
   @jcamachor I have created https://issues.apache.org/jira/browse/HIVE-22135 
for refactoring Hive.get().getConf().
   For the current patch I have gotten green run. Let me know if everything 
looks good to you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to