miklosgergely commented on a change in pull request #757: HIVE-22143 Break up DDLSemanticAnalyzer - extract Database related analyzers URL: https://github.com/apache/hive/pull/757#discussion_r321587474
########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/LoadDatabase.java ########## @@ -21,9 +21,9 @@ import org.apache.hadoop.hive.metastore.api.Database; import org.apache.hadoop.hive.metastore.api.InvalidOperationException; import org.apache.hadoop.hive.ql.ddl.DDLWork; -import org.apache.hadoop.hive.ql.ddl.database.AlterDatabaseSetOwnerDesc; -import org.apache.hadoop.hive.ql.ddl.database.AlterDatabaseSetPropertiesDesc; -import org.apache.hadoop.hive.ql.ddl.database.CreateDatabaseDesc; +import org.apache.hadoop.hive.ql.ddl.database.create.CreateDatabaseDesc; +import org.apache.hadoop.hive.ql.ddl.database.setowner.AlterDatabaseSetOwnerDesc; Review comment: The 3 set operations are all different, with different tokens (TOK_ALTERDATABASE_LOCATION, TOK_ALTERDATABASE_OWNER, TOK_ALTERDATABASE_PROPERTIES), and different parseable data, so the logic of the ddl requires them to be separate. What I'd suggest is to have a "org.apache.hadoop.hive.ql.ddl.database.alter" package, and under that a separate "location", "owner", and "properties" package for the 3 types. Please let me know what you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
