nishantmonu51 commented on a change in pull request #723: [HIVE-20683] Add the
Ability to push Dynamic Between and Bloom filters to Druid
URL: https://github.com/apache/hive/pull/723#discussion_r322256307
##########
File path:
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java
##########
@@ -894,4 +945,255 @@ public static IndexSpec getIndexSpec(Configuration jc) {
ImmutableList<AggregatorFactory> aggregatorFactories =
aggregatorFactoryBuilder.build();
return Pair.of(dimensions, aggregatorFactories.toArray(new
AggregatorFactory[0]));
}
+
+ // Druid only supports String,Long,Float,Double selectors
+ private static Set<TypeInfo> druidSupportedTypeInfos =
ImmutableSet.<TypeInfo>of(
+ TypeInfoFactory.stringTypeInfo, TypeInfoFactory.charTypeInfo,
+ TypeInfoFactory.varcharTypeInfo, TypeInfoFactory.byteTypeInfo,
+ TypeInfoFactory.intTypeInfo, TypeInfoFactory.longTypeInfo,
+ TypeInfoFactory.shortTypeInfo, TypeInfoFactory.doubleTypeInfo
+ );
+
+ private static Set<TypeInfo> stringTypeInfos = ImmutableSet.<TypeInfo>of(
+ TypeInfoFactory.stringTypeInfo,
+ TypeInfoFactory.charTypeInfo, TypeInfoFactory.varcharTypeInfo
+ );
+
+
+ public static org.apache.druid.query.Query
addDynamicFilters(org.apache.druid.query.Query query,
+ ExprNodeGenericFuncDesc filterExpr, Configuration conf, boolean
resolveDynamicValues
+ ) {
+ List<VirtualColumn> virtualColumns = Arrays
+ .asList(getVirtualColumns(query).getVirtualColumns());
+ org.apache.druid.query.Query rv = query;
+ DimFilter joinReductionFilter = toDruidFilter(filterExpr, conf,
virtualColumns,
+ resolveDynamicValues
+ );
+ if(joinReductionFilter != null) {
+ String type = query.getType();
+ DimFilter filter = new AndDimFilter(joinReductionFilter,
query.getFilter());
+ switch (type) {
+ case org.apache.druid.query.Query.TIMESERIES:
+ rv = Druids.TimeseriesQueryBuilder.copy((TimeseriesQuery) query)
+ .filters(filter)
+ .virtualColumns(VirtualColumns.create(virtualColumns))
+ .build();
+ break;
+ case org.apache.druid.query.Query.TOPN:
+ rv = new TopNQueryBuilder((TopNQuery) query)
+ .filters(filter)
+ .virtualColumns(VirtualColumns.create(virtualColumns))
+ .build();
+ break;
+ case org.apache.druid.query.Query.GROUP_BY:
+ rv = new GroupByQuery.Builder((GroupByQuery) query)
+ .setDimFilter(filter)
+ .setVirtualColumns(VirtualColumns.create(virtualColumns))
+ .build();
+ break;
+ case org.apache.druid.query.Query.SCAN:
+ rv = ScanQuery.ScanQueryBuilder.copy((ScanQuery) query)
+ .filters(filter)
+ .virtualColumns(VirtualColumns.create(virtualColumns))
+ .build();
+ break;
+ case org.apache.druid.query.Query.SELECT:
+ rv = Druids.SelectQueryBuilder.copy((SelectQuery) query)
+ .filters(filter)
+ .virtualColumns(VirtualColumns.create(virtualColumns))
+ .build();
+ break;
+ default:
+ throw new UnsupportedOperationException("Unsupported Query type " +
type);
+ }
+ }
+ return rv;
+ }
+
+ @Nullable
+ private static DimFilter toDruidFilter(ExprNodeDesc filterExpr,
Configuration configuration,
+ List<VirtualColumn> virtualColumns, boolean resolveDynamicValues
+ ) {
+ if(filterExpr == null) {
+ return null;
+ }
+ Class<? extends GenericUDF> genericUDFClass =
getGenericUDFClassFromExprDesc(filterExpr);
+ if(FunctionRegistry.isOpAnd(filterExpr)) {
+ Iterator<ExprNodeDesc> iterator = filterExpr.getChildren().iterator();
+ List<DimFilter> delegates = Lists.newArrayList();
+ while (iterator.hasNext()) {
+ DimFilter filter = toDruidFilter(iterator.next(), configuration,
virtualColumns,
+ resolveDynamicValues
+ );
+ if(filter != null) {
+ delegates.add(filter);
+ }
+ }
+ if(delegates != null && !delegates.isEmpty()) {
Review comment:
removed null check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
