ashutosh-bapat commented on a change in pull request #793: HIVE-22267 : Support
password based authentication for HMS along-side kerberos authentication.
URL: https://github.com/apache/hive/pull/793#discussion_r331487455
##########
File path:
itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/metastore/security/TestHadoopAuthBridge23.java
##########
@@ -94,16 +94,15 @@ public Server() throws TTransportException {
super();
}
@Override
- public TTransportFactory createTransportFactory(Map<String, String>
saslProps)
- throws TTransportException {
+ public TSaslServerTransport.Factory
createSaslServerTransportFactory(Map<String, String> saslProps) {
TSaslServerTransport.Factory transFactory =
new TSaslServerTransport.Factory();
transFactory.addServerDefinition(AuthMethod.DIGEST.getMechanismName(),
null, SaslRpcServer.SASL_DEFAULT_REALM,
saslProps,
new SaslDigestCallbackHandler(secretManager));
- return new TUGIAssumingTransportFactory(transFactory, realUgi);
Review comment:
Earlier HiveMetaStore was using createTransportFactory to create a transport
factory. But now we are not using it. Instead, we are using
createSaslServerTransportFactory, which should not create a wrapped transport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
