kgyrtkirk commented on a change in pull request #787: HIVE-22239
URL: https://github.com/apache/hive/pull/787#discussion_r332353993
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
##########
@@ -316,7 +321,7 @@ public Object process(Node nd, Stack<Node> stack,
NodeProcessorCtx procCtx,
protected long evaluateExpression(Statistics stats, ExprNodeDesc pred,
AnnotateStatsProcCtx aspCtx, List<String> neededCols,
- Operator<?> op, long currNumRows) throws SemanticException {
+ Operator<?> op, long currNumRows, boolean uniformWithinRange) throws
SemanticException {
Review comment:
this boolean is not used in this function ; but aspCtx can be used to obtain
it - I would suggest to either:
* leave the function signature as is and get the boolean when its needed
from conf
* this class is constructed and used to optimize a single query - so we may
pass the conf on consturction and create a finalized field from this info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
