vineetgarg02 commented on a change in pull request #809: HIVE-22274: upgrade
Calcite to 1.21
URL: https://github.com/apache/hive/pull/809#discussion_r334602095
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java
##########
@@ -225,7 +225,7 @@ public JoinPredicateInfo getJoinPredicateInfo() {
private boolean containsOuter() {
for (JoinRelType joinType : joinTypes) {
- if (joinType != JoinRelType.INNER) {
+ if (joinType != JoinRelType.INNER && joinType != JoinRelType.SEMI) {
Review comment:
It would be better to whitelist this for outer types (FULL, LEFT, RIGHT).
@scarlin-cloudera Either we can create separate jira or we can make the
change with this patch..upto you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
