b-slim commented on a change in pull request #818: HIVE-22298: Allow Llap IO
cache for reading tables without delete delta
URL: https://github.com/apache/hive/pull/818#discussion_r335596798
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
##########
@@ -273,38 +273,17 @@ public long getColumnarProjectionSize() {
@Override
public boolean canUseLlapIo(Configuration conf) {
- final boolean hasDelta = deltas != null && !deltas.isEmpty();
- final boolean isAcidRead = AcidUtils.isFullAcidScan(conf);
- final boolean isVectorized = Utilities.getIsVectorized(conf);
- Boolean isSplitUpdate = null;
- if (isAcidRead) {
- final AcidUtils.AcidOperationalProperties acidOperationalProperties
- = AcidUtils.getAcidOperationalProperties(conf);
- isSplitUpdate = acidOperationalProperties.isSplitUpdate();
- // TODO: this is brittle. Who said everyone has to upgrade using upgrade
process?
- assert isSplitUpdate : "should be true in Hive 3.0";
- }
-
- if (isOriginal) {
- if (!isAcidRead && !hasDelta) {
- // Original scan only
- return true;
+ if (AcidUtils.isFullAcidScan(conf)) {
+ if (HiveConf.getBoolVar(conf, ConfVars.LLAP_IO_ACID_ENABLED)
+ && Utilities.getIsVectorized(conf)) {
+ boolean hasDeleteDelta = deltas != null && !deltas.isEmpty();
+ return VectorizedOrcAcidRowBatchReader.canUseLlapIoForAcid(this,
hasDeleteDelta, conf);
+ } else {
+ return false;
Review comment:
can we add a warn log line to help debug this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
