kgyrtkirk commented on a change in pull request #794: HIVE-21884 URL: https://github.com/apache/hive/pull/794#discussion_r335329230
########## File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/ScheduledQueryCreationRegistryHook.java ########## @@ -0,0 +1,38 @@ +package org.apache.hadoop.hive.ql.hooks; + +import java.util.HashSet; +import java.util.Set; + +import org.apache.hadoop.hive.ql.parse.ASTNode; +import org.apache.hadoop.hive.ql.parse.AbstractSemanticAnalyzerHook; +import org.apache.hadoop.hive.ql.parse.HiveParser; +import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHookContext; +import org.apache.hadoop.hive.ql.parse.SemanticException; + +/** + * This hook helps to do some cleanup after tests are creating scheduled queries. Review comment: it's only for tests; but other hooks are here too...there are quite a few interesting ones (like:DummySemanticAnalyzerHook, DummySemanticAnalyzerHook1)....I think it would make sense to move them - but if we do that; move all of them to a new home... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
