kgyrtkirk commented on a change in pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r335671428
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
##########
@@ -196,7 +196,11 @@
DROP_POOL("DROP POOL", HiveParser.TOK_DROP_POOL, null, null, false, false),
CREATE_MAPPING("CREATE MAPPING", HiveParser.TOK_CREATE_MAPPING, null, null,
false, false),
ALTER_MAPPING("ALTER MAPPING", HiveParser.TOK_ALTER_MAPPING, null, null,
false, false),
- DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_MAPPING, null, null, false,
false);
+ DROP_MAPPING("DROP MAPPING", HiveParser.TOK_DROP_MAPPING, null, null, false,
false),
+ CREATE_SCHEDULED_QUERY("CREATE SCHEDULED QUERY",
HiveParser.TOK_CREATE_SCHEDULED_QUERY, null, null),
+ ALTER_SCHEDULED_QUERY("ALTER SCHEDULED QUERY",
HiveParser.TOK_ALTER_SCHEDULED_QUERY, null, null),
+ DROP_SCHEDULED_QUERY("DROP SCHEDULED QUERY",
HiveParser.TOK_DROP_SCHEDULED_QUERY, null, null),
Review comment:
the ';' was already in a newline - to facilitate easier addition of new enum
entries - in these cases I used to leave one trailing ',' at the end...so that
when someone else adds new things - doesn't have to modify the last line; by
adding that comma - which may also make the patch more cherry-pick friendly...
but I've removed it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
