kgyrtkirk commented on issue #819: HIVE-22363 ReduceDeduplication may leave an 
invalid GroupByOperator behind in some cases
URL: https://github.com/apache/hive/pull/819#issuecomment-544947479
 
 
   > @kgyrtkirk , I left some comments. I still do not understand the problem 
we were having with Filter operator. Could you describe how the plan was 
looking before and after, and what we are trying to accomplish? Were we 
producing incorrect results? Were we missing a possible optimization?
   
   There was an incorrect operator left in the plan; which was operating in 
PARTIAL1 mode ; and it caused some classcastexceptions.
   
   The logic was after the detection of  something like this:
   {code}
   pRS-pGBY-cRS-cGBY
   {code}
   
   the problematic case was something like this:
   {code}
   pRS-pGBY-FIL-cRS-cGBY
   {code}
   
   note that it also accepted cases like:
   {code}
   pRS-xGBY-pGBY-cRS-cGBY
   {code}

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to