scarlin-cloudera commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r337648851
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
 ##########
 @@ -118,7 +118,7 @@ protected void perform(final RelOptRuleCall call, final 
ImmutableBitSet topRefs,
       call.transformTo(topOperator.copy(topOperator.getTraitSet(), 
ImmutableList.of(left)));
       return;
     }
-    if (join.getJoinType() != JoinRelType.INNER) {
+    if (join.getJoinType() != JoinRelType.INNER && !join.isSemiJoin()) {
 
 Review comment:
   I will take a closer look at this, you're probably right, we can either 
avoid the check or bail out immediately

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to