shameersss1 commented on a change in pull request #829: Hive JDBC Storage 
Handler: Support For Writing Data to JDBC Data Source
URL: https://github.com/apache/hive/pull/829#discussion_r340521488
 
 

 ##########
 File path: ql/src/test/results/clientpositive/llap/jdbc_handler.q.out
 ##########
 @@ -118,6 +118,25 @@ POSTHOOK: type: QUERY
 POSTHOOK: Input: default@ext_simple_derby_table
 #### A masked pattern was here ####
 200
+PREHOOK: query: insert into ext_simple_derby_table values(100)
+PREHOOK: type: QUERY
+PREHOOK: Input: _dummy_database@_dummy_table
+PREHOOK: Output: default@ext_simple_derby_table
+POSTHOOK: query: insert into ext_simple_derby_table values(100)
+POSTHOOK: type: QUERY
+POSTHOOK: Input: _dummy_database@_dummy_table
+POSTHOOK: Output: default@ext_simple_derby_table
+PREHOOK: query: select * from ext_simple_derby_table
+PREHOOK: type: QUERY
+PREHOOK: Input: default@ext_simple_derby_table
+#### A masked pattern was here ####
+POSTHOOK: query: select * from ext_simple_derby_table
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@ext_simple_derby_table
+#### A masked pattern was here ####
+20
+200
+100
 PREHOOK: query: CREATE EXTERNAL TABLE tables
 
 Review comment:
   > Can we add additional testing? For instance:
   > 
   > 1. Inserting rows with column values using all different Hive primitive 
types (boolean, tinyint, smallint, int, bigint, float, double, decimal, char, 
varchar, string, date, timestamp, etc.)? If any of those types are not 
supported, e.g., complex types, we already throw a user friendly error but 
please add a negative tests for those.
   > 2. Inserting multiple rows.
   > 3. CTAS statement.
   
   Added more test cases!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to