jcamachor commented on a change in pull request #831: HIVE-22238 pkfk URL: https://github.com/apache/hive/pull/831#discussion_r341456163
########## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ########## @@ -1961,6 +1961,7 @@ public static void updateStats(Statistics stats, long newNumRows, newDV = (long) Math.ceil(ratio * oldDV); } cs.setCountDistint(newDV); + cs.setFilterColumn(); Review comment: Apparently `public static void updateStats` is called for joins too. Should we limit setting this column to filter operators (we could pass in the context whether this is applicable or not)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org