jcamachor commented on a change in pull request #833: Hive JDBC Storage
Handler: Incorrect results fetched from BOOLEAN and TIMESTAMP DataType From
JDBC Data Source
URL: https://github.com/apache/hive/pull/833#discussion_r341823804
##########
File path: common/src/java/org/apache/hadoop/hive/common/type/Timestamp.java
##########
@@ -88,6 +88,10 @@ public Timestamp(Timestamp t) {
this(t.localDateTime);
}
+ public Timestamp(java.sql.Timestamp ts) {
Review comment:
Could you remove this new constructor and use existing methods in
`Timestamp` class to create the object (maybe you can encapsulate logic in
utility method in JdbcSerDe)? `java.sql.Timestamp` is used in some places in
Hive with UTC time zone vs system time zone and this constructor may make
things confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
