jcamachor commented on a change in pull request #817: HIVE-22347 Break up DDLSemanticAnalyzer - extract Other analyzers URL: https://github.com/apache/hive/pull/817#discussion_r342908720
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/insert/commit/hook/InsertCommitHookOperation.java ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.hadoop.hive.ql.ddl.misc; +package org.apache.hadoop.hive.ql.ddl.misc.insert.commit.hook; Review comment: Maybe all these could stay under misc package. I am not sure we need so many individual packages with single classes at this level. Or at least we could have more general packages, e.g., hooks, metadata. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
