dlavati commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r344111601
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableDesc.java
##########
@@ -62,8 +62,8 @@ public AlterTableType getType() {
}
@Explain(displayName = "table name", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
- public String getTableName() {
- return tableName;
+ public String getDbTableName() {
Review comment:
Currently the 2 methods are returning the same value, however one adds an
explain, while the other is inherited and is used in e.g.
`Driver:acquireLocks()`. I'd say these are 2 separate use cases (e.g. I
wouldn't want `acquireLocks` to generate that much output with the explain), so
I'd rather just rename one of them to make it more self-explanatory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
