t3rmin4t0r commented on a change in pull request #846: HIVE-22463 decimal64 
multiplication
URL: https://github.com/apache/hive/pull/846#discussion_r348781677
 
 

 ##########
 File path: 
ql/src/test/results/clientpositive/vector_decimal64_mul_decimal64column.q.out
 ##########
 @@ -0,0 +1,142 @@
+PREHOOK: query: create external table 
vector_decimal64_mul_decimal64column(ss_ext_list_price decimal(7,2), 
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), 
ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' 
LINES TERMINATED BY '\n' STORED AS TEXTFILE
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@vector_decimal64_mul_decimal64column
+POSTHOOK: query: create external table 
vector_decimal64_mul_decimal64column(ss_ext_list_price decimal(7,2), 
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), 
ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' 
LINES TERMINATED BY '\n' STORED AS TEXTFILE
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64column
+PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' 
OVERWRITE INTO TABLE vector_decimal64_mul_decimal64column
+PREHOOK: type: LOAD
+#### A masked pattern was here ####
+PREHOOK: Output: default@vector_decimal64_mul_decimal64column
+POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' 
OVERWRITE INTO TABLE vector_decimal64_mul_decimal64column
+POSTHOOK: type: LOAD
+#### A masked pattern was here ####
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64column
+PREHOOK: query: create table 
vector_decimal64_mul_decimal64column_tmp(ss_ext_list_price decimal(7,2), 
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), 
ss_ext_sales_price decimal(7,2)) stored as ORC
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp
+POSTHOOK: query: create table 
vector_decimal64_mul_decimal64column_tmp(ss_ext_list_price decimal(7,2), 
ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), 
ss_ext_sales_price decimal(7,2)) stored as ORC
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp
+PREHOOK: query: insert into table vector_decimal64_mul_decimal64column_tmp 
select * from vector_decimal64_mul_decimal64column
+PREHOOK: type: QUERY
+PREHOOK: Input: default@vector_decimal64_mul_decimal64column
+PREHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp
+POSTHOOK: query: insert into table vector_decimal64_mul_decimal64column_tmp 
select * from vector_decimal64_mul_decimal64column
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@vector_decimal64_mul_decimal64column
+POSTHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp
+POSTHOOK: Lineage: 
vector_decimal64_mul_decimal64column_tmp.ss_ext_discount_amt SIMPLE 
[(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_discount_amt,
 type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_list_price 
SIMPLE 
[(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_list_price,
 type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_sales_price 
SIMPLE 
[(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_sales_price,
 type:decimal(7,2), comment:null), ]
+POSTHOOK: Lineage: 
vector_decimal64_mul_decimal64column_tmp.ss_ext_wholesale_cost SIMPLE 
[(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_wholesale_cost,
 type:decimal(7,2), comment:null), ]
+PREHOOK: query: explain vectorization detail select 
sum(ss_ext_list_price*ss_ext_discount_amt) from 
vector_decimal64_mul_decimal64column_tmp
+PREHOOK: type: QUERY
+PREHOOK: Input: default@vector_decimal64_mul_decimal64column_tmp
+#### A masked pattern was here ####
+POSTHOOK: query: explain vectorization detail select 
sum(ss_ext_list_price*ss_ext_discount_amt) from 
vector_decimal64_mul_decimal64column_tmp
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@vector_decimal64_mul_decimal64column_tmp
+#### A masked pattern was here ####
+PLAN VECTORIZATION:
+  enabled: true
+  enabledConditionsMet: [hive.vectorized.execution.enabled IS true]
+
+STAGE DEPENDENCIES:
+  Stage-1 is a root stage
+  Stage-0 depends on stages: Stage-1
+
+STAGE PLANS:
+  Stage: Stage-1
+    Map Reduce
+      Map Operator Tree:
+          TableScan
+            alias: vector_decimal64_mul_decimal64column_tmp
+            Statistics: Num rows: 1000 Data size: 224000 Basic stats: COMPLETE 
Column stats: COMPLETE
+            TableScan Vectorization:
+                native: true
+                vectorizationSchemaColumns: 
[0:ss_ext_list_price:decimal(7,2)/DECIMAL_64, 
1:ss_ext_wholesale_cost:decimal(7,2)/DECIMAL_64, 
2:ss_ext_discount_amt:decimal(7,2)/DECIMAL_64, 
3:ss_ext_sales_price:decimal(7,2)/DECIMAL_64, 
4:ROW__ID:struct<writeid:bigint,bucketid:int,rowid:bigint>]
+            Select Operator
+              expressions: (ss_ext_list_price * ss_ext_discount_amt) (type: 
decimal(15,4))
 
 Review comment:
   2 * 2 = scale 4, so the scaling is not needed in the inner loop at all

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to